Split sync and async API #50
Conversation
|
I'll go ahead and merge this. |
| let user_defaults: *mut NSObject = msg_send![class!(NSUserDefaults), standardUserDefaults]; | ||
| let apple_domain = NSString::from_str("Apple Global Domain"); | ||
| let dict: *mut NSObject = msg_send![user_defaults, persistentDomainForName:&*apple_domain]; | ||
|
|
||
| if !dict.is_null() { | ||
| let style_key = NSString::from_str("AppleInterfaceStyle"); | ||
| let style: *mut NSObject = msg_send![dict, objectForKey:&*style_key]; | ||
|
|
||
| if !style.is_null() { | ||
| // Compare with "Dark" | ||
| let dark_str = NSString::from_str("Dark"); | ||
| let is_dark: bool = msg_send![style, isEqualToString:&*dark_str]; | ||
| is_dark | ||
| } else { | ||
| false | ||
| } | ||
| } else { | ||
| false | ||
| } |
There was a problem hiding this comment.
Tip: You can avoid the brittle msg_send! here by importing NSUserDefaults from objc2-foundation (might have to modify Cargo.toml to include the "NSUserDefaults" Cargo feature first).
|
The new synchronous |
|
We could instead provide only the sync version of |
|
I didn't consider that using |
This pull request introduces several changes to the codebase to add support for both synchronous and asynchronous detection and subscription to system theme changes.
The changes include modifications to dependencies, new feature flags, and refactoring of existing code to accommodate the new functionality.
Warning
These are breaking changes, we should consider shipping v2.0.0 after merging this.
Dependency and feature flag updates:
Cargo.toml: Addedsyncfeature flag and updatedpollsterto be optional. Introduced new example paths forsyncand added thecocoaandobjcdependencies for macOS support.Refactoring and new functionality:
src/lib.rs: Moved theModeenum to a newmodemodule and updated thedetectandsubscribefunctions to support both synchronous and asynchronous operations.src/mode.rs: Created a new module for theModeenum and its associated methods.src/platforms/*: Refactored platform-specific detection and subscription functions to support both synchronous and asynchronous operations. This includes changes in macOS, freedesktop, websys, and windows modules.Example updates:
examples/async.rs: Added a new asynchronous example demonstrating the use of thedetectandsubscribefunctions.examples/sync.rs: Added a new synchronous example demonstrating the use of thedetectandsubscribefunctions.detect.rsandnotify.rsas they were replaced by the newasync.rsandsync.rsexamples.Fixes: